Repository navigation
feat(desktop): a pull request pane is keyed by repository and number - #7823
Merged
Merged
Conversation
saddlepaddle
temporarily deployed
to
preview
September 24, 2026 21:55 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (55)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
saddlepaddle
had a problem deploying
to
preview
September 24, 2026 21:56 — with
GitHub Actions
Error
GitHub Actions
Error
saddlepaddle
had a problem deploying
to
preview
September 24, 2026 21:56 — with
GitHub Actions
Error
GitHub Actions
Error
saddlepaddle
had a problem deploying
to
preview
September 24, 2026 21:56 — with
GitHub Actions
Error
GitHub Actions
Error
saddlepaddle
had a problem deploying
to
preview
September 24, 2026 21:56 — with
GitHub Actions
Error
GitHub Actions
Error
saddlepaddle
had a problem deploying
to
preview
September 24, 2026 21:56 — with
GitHub Actions
Error
GitHub Actions
Error
|
No installed development build can load this pull request as an update: its native fingerprint is |
The pane's data was `{ prNumber }` and it borrowed the repository from
whatever workspace it was open in, so it needed a project to render and
showed "Choose a project" on a cloud workspace whose host row had not
arrived. A number only means something inside a repository; with
multi-repo workspaces the borrowed one is ambiguous, and with cloud
boxes it is absent.
The pane, the intent store and every opener now carry the PR's own
identity, `{ repoFullName, number }`, parsed from the PR's URL where an
opener only had that. One vocabulary for what a PR looks like lives in
@superset/shared/pull-request; the API builds it once from the webhook
row (getByBranches now returns it normalized) and the host's `gh pr view`
output maps into it through one adapter. A new integration.github.
getPullRequest serves a PR's content by repository and number with the
installation's token.
The pane reads through the workspace's host when its project is the PR's
repository — the person's own gh, no GitHub App required, unchanged for
every local and remote host — and through the API otherwise, which is
what a closed cloud box or a PR in a repository nobody has checked out
needs. Threads and the close/merge actions stay host-side for the
workspace's linked PR.
Claude-Session: https://claude.ai/code/session_01RL946q6aRucLVJs659sW24
saddlepaddle
force-pushed
the
pr-pane-identity
branch
from
September 24, 2026 21:57
09e4b9f to
98ba9cc
Compare
Contributor
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
saddlepaddle
temporarily deployed
to
preview
September 24, 2026 21:57 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
saddlepaddle
temporarily deployed
to
preview
September 24, 2026 21:58 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
saddlepaddle
temporarily deployed
to
preview
September 24, 2026 21:58 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
saddlepaddle
temporarily deployed
to
preview
September 24, 2026 21:58 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
saddlepaddle
temporarily deployed
to
preview
September 24, 2026 21:58 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
saddlepaddle
temporarily deployed
to
preview
September 24, 2026 21:58 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
superset-app Bot
pushed a commit
that referenced
this pull request
Sep 24, 2026
`bunx turbo run typecheck` failed on CI while passing on the branch alone: CI
builds the PR's merge commit, and this is a semantic conflict main and the
branch each look fine on their own.
src/router/integration/github/github.ts(332,9): error TS2552:
Cannot find name 'githubRepositories'. Did you mean 'listGithubRepositories'?
#7823 added `getPullRequest`, which resolves a repository straight off
`githubRepositories`; this branch dropped that import because nothing here read
the table any more. Git merged both hunks cleanly and the result does not
compile.
Fixing the import alone would have compiled and reopened the hole. That
procedure answers with the *installation's* token, so on the merged tree it
handed any org member the title, body, author and branches of a pull request in
the owner's private repository — the boundary this branch exists to close,
arriving through a door that did not exist when the branch was cut. It now
resolves through `listGithubRepositories`, the gated reader every other query
procedure here already goes through, which removes the dangling symbol and
closes the door in one change. An unreachable repository reads as "not a
repository the GitHub App is installed on", so the refusal does not confirm that
a private repository exists.
Regression test added alongside the other listing-door cases.
Refs SUPER-2432, SUPER-2022
saddlepaddle
added a commit
that referenced
this pull request
Sep 25, 2026
…ository (#7869) A pull-request pane persisted by an earlier build stores only its number, so after #7823 re-keyed the pane by repository and number, reopening a workspace that still had one open threw while rendering the pane header and took down the workspace view. The read-time layout heal now removes such a pane from its tab, promoting its split sibling, and drops a tab left empty. Refs DESKTOP-1BT
Kitenite
added a commit
that referenced
this pull request
Oct 1, 2026
* docs: weekly update for PRs merged 2026-09-23 to 2026-09-30 Source of truth: live Notion SOP "Weekly Docs Update (automation SOP)". Window: merged:>=2026-09-23 (139 PRs). PRs through the morning of 09-23 were covered by #7771. Changes - Pages: no auto-open on publish (#7790); page links and URL links split into their own settings (#7916, #7962, #7946); Listening agents menu with per-row stop and Add listening agent (#7724, #7820, #7919); globe on the Share button (#7766); Report on public pages (#7886); agents offer a page (#7759). Files: pages.mdx, cli/cli-reference.mdx. - Settings moves: Links replaced by Browser and Files & Editor (#7916, #7962). Files: editor.mdx, terminal-integration.mdx, customization.mdx. - Editor: inline rename and drag to move (#7692), Auto Save (#7693, #7916), open and save files outside the workspace (#7897, #7982), Copy as Markdown (#7591), per-pane error screen (#7983). File: editor.mdx. - Terminal copy follows Ghostty's whitespace rules (#7868). File: terminal-integration.mdx. - Agents: UFO (#7898); GPT-6 Astra, Sonnet 5.5, retiring GPT-5.5, retired GPT-5.4/5.3 Codex (#7783, #7894, #7935). Files: agent-integration.mdx, cli/cli-reference.mdx. - Host: superset start --daemon --auto-update and update-lock permission errors (#7735, #7952). Files: cli/host-server.mdx, cli/cli-reference.mdx. - Removed the mcp CLI section and the Connected Service Plugins section: #7776 made plugins/mcp internal, the Plugins page is staff-flagged, and apps/docs/AGENTS.md keeps internal commands out. Files: skills.mdx, cli/cli-reference.mdx. - Slack page unfurls and details panel (#7817, #7821, #7914, #7957). File: use-with-slack.mdx. - Workspaces: instant creation with background naming (#7518); recoverable project deletion (#7896). File: workspaces.mdx. - Shortcuts: prev/next workspace includes Pinned and wraps (#7851); ⌘B collapses the sidebar to a rail (#7964). File: keyboard-shortcuts.mdx. - Ship controls and open-in button moved to the right sidebar strip (#7958). Files: diff-viewer.mdx, use-with-ide.mdx. Deliberately skipped - Cloud workspaces/environments/sandboxes (flag-gated, AGENTS.md rule): #7784 #7795 #7824 #7840 #7844 #7845 #7847 #7849 #7850 #7858 #7861 #7863 #7874 #7911 #7913 #7918 #7922 #7931 #7932 #7937 #7956 #7961 #7969 #7981 #7637 #7794 #7789 #7838 (its CLI docs already shipped in the PR). - Staff-only plugins: #7912 Sentry plugin, #7716, #7727, #7955. - Already documented in their own PRs: #7917, #7921. - Removed feature never documented: #7796 Google Calendar triggers. - Agents chip remove/revert/default-off, never documented: #7870 #7871 #7872. - Billing/backend policy with no docs surface: #7947, #7812, #7786, #7792, #7798, #7761, #7948, #7949, #7951, #7827. - Reverted security trio: #7828 #7829 #7830 (reverted by #7834). - Fixes restoring expected behavior: #7683 #7696 #7707 #7743 #7751 #7756 #7764 #7765 #7781 #7788 #7791 #7823 #7825 #7833 #7837 #7852 #7857 #7860 #7864 #7865 #7869 #7873 #7897-covered #7903 #7938 #7980 #7943 #7964-chrome. - Mobile (no docs page): #7746 #7747 #7748 #7749 #7750 #7782 #7793 #7810 #7814 #7816 #7889 #7968. - Marketing, internal docs, CI, version bumps: #7651 #7744 #7752 #7771 #7774 #7776-infra #7777 #7785 #7811 #7818 #7822 #7826 #7834 #7884 #7885 #7895 #7909 #7933 #7934 #7942 #7944 #7965 #7966. Validation: bun run --cwd apps/docs typecheck, bun run lint:fix, bun run lint (exit 0), Vale on 13 changed files (0 errors, 0 warnings), git diff --check. * chore: log weekly docs update follow-ups * docs: tighten review findings in the weekly update Only the page creator can stop or add listening agents. On focus change also saves on window blur, and Auto Save pauses on conflicts. Taken-down pages do not unfurl. Model picker coverage matches agent-models.ts.
This was referenced Oct 20, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The workspace PR pane is identified by the PR's own key,
{ repoFullName, number }, instead of{ prNumber }plus whatever project the workspace happened to have. Every opener feeds it: sidebar chip, Workspaces list row, ShipControl's toast, the diff pane's PR link, the Changes menu, the Review tab title, and the browser pane's "Open in app" (which no longer needs a matching project to show).Two sources, one shape.
@superset/shared/pull-requestowns the vocabulary (PullRequestDetail, checks, state, review decision). The API normalizes once (getByBranchesnow returns it; newintegration.github.getPullRequestserves content by repo + number with the installation token). The host'sgh pr viewoutput maps into it throughfromHostPullRequestContent.Source rule (
usePullRequestPaneDetail): the workspace's host when its project is the PR's repository — the person's owngh, no GitHub App needed, unchanged for local and remote hosts — else the API, which is what a closed cloud box or a PR in a repo nobody has checked out needs. The API query waits for host projects to answer so it never fires speculatively. Threads and close/merge stay host-side for the workspace's linked PR. The/pull-requestspage is host-only as before.Why
A number only means something inside a repository. Borrowing the repo from the workspace broke on cloud boxes ("Choose a project from Pull requests…" while the host row hadn't arrived) and is ambiguous once a workspace has several repos (#7699,
cloud_workspace_repositories).Verified
Dev app, real clicks over CDP:
pullRequests.getContent.github.com/superset-sh/mastra/pull/9→ "Open in app" → pane called onlyintegration.github.getPullRequest(no host call). It rendered the error state because the dev.env's GitHub App isn't the one behind the prod installation row; the same request is verified on prod after deploy (closed box + test: cloud sidebar PR chip proof (close me) #7799).openPullRequestPaneInStoreandgetPullRequestTargetsuites), trpc, i18n 157/157; root typecheck 42/42; the one new server-error string is translated in all 16 locales.Existing saved PR panes carry the old
{ prNumber }shape and show an error until reopened — panes are transient, and reopening is one click.Follow-ups (not in this PR)
/pull-requests/$prNumberpage keyed by repo, so a PR opens there without a project too.V2WorkspacePrSummary,LinkedPR,DashboardSidebarWorkspacePullRequest,PRIcon.PRState, the host's two state enums) onto the shared type.pullRequestRef, the adapter and the source rule into a package mobile can import, alongside the cloud-workspace sync logic.https://claude.ai/code/session_01RL946q6aRucLVJs659sW24
Summary by cubic
Keys the workspace PR pane by
{ repoFullName, number }instead of the pane's{ prNumber }plus whatever project the workspace had open, so a PR opens even when no host has that repo checked out (cloud boxes, multi-repo workspaces).The pane reads from the workspace's host when its project is the PR's repository, and falls back to the new
integration.github.getPullRequestusing the GitHub App installation otherwise. All openers now pass the ref parsed from the PR URL, and@superset/shared/pull-requestunifies the detail shape across the API and host output.Migration
{ prNumber }shape show an error until reopened; panes are transient and reopening restores them.Written for commit 98ba9cc. Summary will update on new commits.
Summary by CodeRabbit